Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer usage #303

Open
acolytec3 opened this issue Jan 8, 2025 · 2 comments
Open

Buffer usage #303

acolytec3 opened this issue Jan 8, 2025 · 2 comments

Comments

@acolytec3
Copy link
Contributor

Once #302 gets merged, we remove bcrypto which I believe was the main reason for continuing to use Buffer instead of Uint8Array everywhere. Is that correct or are there other reasons to continue using Buffer in this library? If not, would you be open to a PR to remove all the Buffer to/from which is just an unnecessary set of conversions that muck up the APIs.
@wemeetagain
Copy link
Member

I don't think there's a reason to continue using Buffer now :)

@acolytec3
Copy link
Contributor Author

Awesome, will pick this one up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wemeetagain @acolytec3