Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats db metrics #2433

Closed
3 tasks
elmattic opened this issue Jan 16, 2023 · 0 comments · Fixed by #2444
Closed
3 tasks

Fix stats db metrics #2433

elmattic opened this issue Jan 16, 2023 · 0 comments · Fixed by #2444
Assignees
Labels
Type: Bug Something isn't working Type: Enhancement

Comments

@elmattic
Copy link
Contributor

Issue summary

Typing http://localhost:6116/stats/db in a browser when Forest + paritydb backend is running results in:

# RocksDB statistics:
Not enabled. Set enable_statistics to true in config and restart daemon

We would like proper comment and help message to enable db statistics. Ie:

# ParityDb statistics:
Not enabled. Set stats to true in parity_db section and restart daemon

But even when forcing stats to true in default ParityDbConfig constructor shows nothing.

Acceptance Criteria

  • Proper metrics comment and help message is shown when ParityDb backend is used
  • ParityDb stats are correctly displayed
  • Make sure everything still works for RocksDB backend

Other information and links

async fn collect_db_metrics<DB>(

@elmattic elmattic added Type: Bug Something isn't working Type: Enhancement labels Jan 16, 2023
@LesnyRumcajs LesnyRumcajs self-assigned this Jan 17, 2023
@elmattic elmattic added this to the Forest 🌲 Infrastructure milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: Enhancement
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants