Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Forest send command behavior with the one from Lotus #2668

Closed
4 tasks done
elmattic opened this issue Mar 15, 2023 · 2 comments
Closed
4 tasks done

Align Forest send command behavior with the one from Lotus #2668

elmattic opened this issue Mar 15, 2023 · 2 comments
Assignees
Labels
Ready Issue is ready for work and anyone can freely assign it to themselves

Comments

@elmattic
Copy link
Contributor

elmattic commented Mar 15, 2023

Issue summary

Lotus send command allows to specify the token amount in either FIL or attoFIL denominations.
That's not the case for Forest send command where it expects attoFIL.

  • Add support of similar behaviour.
  • Add tests covering the different denominations.
  • Update the documentation accordingly.
  • Make sure sendFIL still works in the JavaScript console

Other information and links

https://github.com/filecoin-project/lotus/blob/master/cli/send.go#L96
https://github.com/filecoin-project/lotus/blob/master/chain/types/fil.go#L86

@elmattic elmattic added the Ready Issue is ready for work and anyone can freely assign it to themselves label Mar 15, 2023
@LesnyRumcajs
Copy link
Member

I'd also add a strong emphasis on updating the documentation. The user sending 1e18 FIL by just following the docs may get confused. https://github.com/ChainSafe/forest/blob/main/documentation/src/docker.md

@elmattic elmattic changed the title Aligning Forest send command behavior with the one from Lotus Align Forest send command behavior with the one from Lotus Mar 15, 2023
@elmattic
Copy link
Contributor Author

I'd also add a strong emphasis on updating the documentation. The user sending 1e18 FIL by just following the docs may get confused. https://github.com/ChainSafe/forest/blob/main/documentation/src/docker.md

Very good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Issue is ready for work and anyone can freely assign it to themselves
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants