Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate genesis pledge mismatch #2937

Open
LesnyRumcajs opened this issue Jun 6, 2023 · 0 comments
Open

Investigate genesis pledge mismatch #2937

LesnyRumcajs opened this issue Jun 6, 2023 · 0 comments
Labels
Node Priority: 4 - Low Limited impact and can be implemented at any time Type: Bug Something isn't working

Comments

@LesnyRumcajs
Copy link
Member

Issue summary
While working on the #2910 we discovered that there's a mismatch in the genesis pledge.

genesis_pledge: TokenAmount,

In the Forest implementation, it's hard-coded to 0, while in Lotus it follows a bit more sophisticated logic with a call to the Power actor.

This, in turn, leaves Forest with 0 for the genesis pledge and Lotus with 2 attoFIL. It doesn't appear to be consensus-critical but may surface in the future, and it would be good to align with the Lotus implementation. Otherwise, we should consider removing it if it's not used at all.

Other information and links

@LesnyRumcajs LesnyRumcajs added Priority: 4 - Low Limited impact and can be implemented at any time Node labels Jun 6, 2023
@LesnyRumcajs LesnyRumcajs mentioned this issue Jun 6, 2023
12 tasks
@lemmih lemmih added the Type: Bug Something isn't working label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Node Priority: 4 - Low Limited impact and can be implemented at any time Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants