Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoist the tipset re-validator into forest-cli snapshot validate #3071

Closed
lemmih opened this issue Jun 26, 2023 · 0 comments · Fixed by #3167
Closed

Hoist the tipset re-validator into forest-cli snapshot validate #3071

lemmih opened this issue Jun 26, 2023 · 0 comments · Fixed by #3167
Assignees
@sudo-shashank
Labels
Ready Issue is ready for work and anyone can freely assign it to themselves

Comments

@lemmih
Copy link
Contributor

lemmih commented Jun 26, 2023

Issue summary

When loading a snapshot, Forest has a flag for re-validating a range of already-computed tipsets. This is great for testing, but this functionality belongs outside the daemon. Re-validating tipsets does not require connecting to the p2p network, nor does it modify the database. We should move the re-validation to forest-cli. It could live in the forest-cli snapshot validate sub-command. Perhaps under a --validate-tipset-range=X..Y or --validate-tipsets=N flag.

Other information and links
@lemmih lemmih added the Ready Issue is ready for work and anyone can freely assign it to themselves label Jun 26, 2023
@sudo-shashank sudo-shashank mentioned this issue Jul 11, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sudo-shashank sudo-shashank

Labels
Ready Issue is ready for work and anyone can freely assign it to themselves
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a new option --validate-tipsets in forest-cli validate command ChainSafe/forest
2 participants
@lemmih @sudo-shashank