Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asyncify some verifications of Blocks in the ChainSyncer #410

Closed
ec2 opened this issue May 12, 2020 · 0 comments
Closed

Asyncify some verifications of Blocks in the ChainSyncer #410

ec2 opened this issue May 12, 2020 · 0 comments
Assignees

Comments

@ec2
Copy link
Member

ec2 commented May 12, 2020

Issue summary

There are some checks in the ChainSyncer's validate(&self, block: &Block) -> Result<(), Error> method that could use some async.
This is a nice optimization to have, since checks don't have to happen sequentially. Furthermore, currently when one check fails, the whole method fails. This implies that we can only recover one error per block. When done asynchronously, we can pass back multiple errors, giving us a more rich error.

Some checks that can be async are:
Miner Check, Signature Check, Message Check, Winner Check

Other information and links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants