Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO in PendingSubscriptionSink #4188

Closed
aatifsyed opened this issue Apr 12, 2024 · 5 comments
Closed

TODO in PendingSubscriptionSink #4188

aatifsyed opened this issue Apr 12, 2024 · 5 comments
Assignees
@elmattic

Comments

@aatifsyed
Copy link
Contributor

363aac1#diff-78e932c0563f39b9d22b2cb2cc901ceeac49b68952476be94bb17e40346b9203R127
@aatifsyed
Copy link
Contributor Author

Introduced in #3978

@elmattic
Copy link
Contributor

I think our plan is to get rid of the PendingSubscriptionSink: #4000

@elmattic
Copy link
Contributor

This is some TODO comment originating from the jsonrpsee crate.

@LesnyRumcajs
Copy link
Member

So, should the comment be removed and closed? Otherwise, let's have a meaningful description on what is to be done.

@elmattic
Copy link
Contributor

We can close it.

@LesnyRumcajs LesnyRumcajs mentioned this issue Apr 15, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elmattic elmattic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LesnyRumcajs @elmattic @aatifsyed