Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F3] Implement GPBFT primitives that certs package uses and port certs #4693

Closed
Tracked by #4552
ruseinov opened this issue Aug 29, 2024 · 1 comment · Fixed by ChainSafe/rust-f3#14
Closed
Tracked by #4552
Assignees

Comments

@ruseinov
Copy link
Contributor

ruseinov commented Aug 29, 2024

This issue entails rewriting certs package in Rust.

What needs to be done:

  1. Add Rust dependencies analogous to those in Go, e.g. num-bigint, fvm_ipld_bitfield.
  2. Make sure that the package follows Rust standards and not simply replicated line by line from Go into Rust. That means that we might need to re-shuffle some constants, error-handling and type composition.
  3. Implement gpBFT types needed by the certs package, e.g.PowerTable, ECChain, Verifier and their logic.
  4. Implement the certs package using said dependencies, including gpBFT.

What certs package does, roughly:

  1. Defines FinalityCertificate, which represents a single finalized GPBFT instance.
  2. Allows for verification of FinalityCertificate, thus making sure that finality can be confirmed.
    a. Applies PowerTable diffs.
    b. Verifies FinalityCertificate signatures by means of using the Verifier, which is a trait define in GPBFT. A concrete Verifier must be implemented via blssig package, which can be done as a follow-up issue. We won't be able to test this on real certificates until this is done. Therefore this issue depends on [F3] Implement blssig package. #4705 to be completed, but does not require this package for the actual implementation as Verifier is a generic trait, so it can be mocked.
@ruseinov ruseinov moved this to In progress in Forest Backlog 🌲 Aug 29, 2024
@ruseinov ruseinov self-assigned this Aug 29, 2024
@ruseinov ruseinov changed the title Implement GPBFT primitives that certs package uses and port certs [F3] Implement GPBFT primitives that certs package uses and port certs Oct 2, 2024
@ruseinov
Copy link
Contributor Author

ruseinov commented Oct 10, 2024

This is mostly done, needs a couple more tests and a review.
After that this will be blocked on blssig and gnark libraries for full implementation.
But will work for f3 follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant