You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add Rust dependencies analogous to those in Go, e.g. num-bigint, fvm_ipld_bitfield.
Make sure that the package follows Rust standards and not simply replicated line by line from Go into Rust. That means that we might need to re-shuffle some constants, error-handling and type composition.
Implement gpBFT types needed by the certs package, e.g.PowerTable, ECChain, Verifier and their logic.
Implement the certs package using said dependencies, including gpBFT.
What certs package does, roughly:
Defines FinalityCertificate, which represents a single finalized GPBFT instance.
Allows for verification of FinalityCertificate, thus making sure that finality can be confirmed.
a. Applies PowerTable diffs.
b. Verifies FinalityCertificate signatures by means of using the Verifier, which is a trait define in GPBFT. A concrete Verifier must be implemented via blssig package, which can be done as a follow-up issue. We won't be able to test this on real certificates until this is done. Therefore this issue depends on [F3] Implement blssig package. #4705 to be completed, but does not require this package for the actual implementation as Verifier is a generic trait, so it can be mocked.
The text was updated successfully, but these errors were encountered:
ruseinov
changed the title
Implement GPBFT primitives that certs package uses and port certs
[F3] Implement GPBFT primitives that certs package uses and port certsOct 2, 2024
This is mostly done, needs a couple more tests and a review.
After that this will be blocked on blssig and gnark libraries for full implementation.
But will work for f3 follow.
This issue entails rewriting certs package in Rust.
What needs to be done:
num-bigint, fvm_ipld_bitfield
.PowerTable, ECChain, Verifier
and their logic.What
certs
package does, roughly:FinalityCertificate
, which represents a single finalized GPBFT instance.FinalityCertificate
, thus making sure that finality can be confirmed.a. Applies
PowerTable
diffs.b. Verifies
FinalityCertificate
signatures by means of using theVerifier
, which is a trait define in GPBFT. A concrete Verifier must be implemented viablssig
package, which can be done as a follow-up issue. We won't be able to test this on real certificates until this is done. Therefore this issue depends on [F3] Implementblssig
package. #4705 to be completed, but does not require this package for the actual implementation asVerifier
is a generic trait, so it can be mocked.The text was updated successfully, but these errors were encountered: