feat(rpc): implement Filecoin.F3GetManifest #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
commented
Oct 23, 2024
| @@ -1629,6 +1629,7 @@ fn f3_tests_with_tipset(tipset: &Tipset) -> anyhow::Result<Vec<RpcTest>> { | |||
| // using basic because 2 nodes are not garanteed to be at the same head | |||
| RpcTest::basic(F3GetECPowerTable::request((None.into(),))?), | |||
| RpcTest::identity(F3GetECPowerTable::request((tipset.key().into(),))?), | |||
| RpcTest::identity(F3GetManifest::request(())?), | |||
There was a problem hiding this comment.
Hmm, I will have to disable it in tomorrow's patch release until Lotus makes a release including the initial power table cid
hanabi1224
requested review from
ruseinov and
LesnyRumcajs
and removed request for
a team
LesnyRumcajs
approved these changes
Oct 23, 2024
lemmih
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Filecoin.F3GetManifestReference issue to close (if applicable)
Closes #4923
Other information and links
Change checklist