Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecrecover method in signature.rs #498

Closed
flodesi opened this issue Jun 15, 2020 · 0 comments
Closed

Fix ecrecover method in signature.rs #498

flodesi opened this issue Jun 15, 2020 · 0 comments
Assignees
Labels
Priority: 3 - Medium Nice-to-have, does not impede core functionality Type: Bug Something isn't working

Comments

@flodesi
Copy link
Contributor

flodesi commented Jun 15, 2020

Task summary
Currently, the ecrecover method in signature.rs is panicking due to incorrect code whenever this function is called. This issue will fix this problem as well as update the logic to correctly get an Address given a message hash and Signature.

Specification reference
Refer to go-secp256k1: https://github.com/ipsn/go-secp256k1/blob/9d62b9f0bc52d16160f79bfb84b2bbf0f6276b03/secp256.go#L93
as well as Zondax: https://github.com/Zondax/filecoin-rs/blob/842f61de3c6c3d5d90c5b2ada9d1e342331fe23f/signer/src/lib.rs#L315

@flodesi flodesi added Priority: 3 - Medium Nice-to-have, does not impede core functionality Type: Bug Something isn't working Crypto labels Jun 15, 2020
@flodesi flodesi self-assigned this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 3 - Medium Nice-to-have, does not impede core functionality Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants