You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Equivalent of changes done in #716, a cache for link nodes needs to be added to avoid unnecessary blockstore reads, and along with this change expand the serialization tests to also check the blockstore read and write status with the tracking blockstore added in that PR. Reason this is necessary is because the VM charges gas for every read as well as number of bytes written and number of writes to the blockstore. Without the cache, it will be a mismatch.
With this change, the interface can be changed to return a reference to the element on gets, so try to match the HashMap interface. Only difference really is just that the get value is owned (because it currently needs to be) but would be more efficient if this were not the case.
Also verify cases like: filecoin-project/go-hamt-ipld#65 as I don't think we reorder on child clean (but not sure if we would run into this bug).
Also with this, try to port over as many tests from the go implementation to verify compatibility, for example filecoin-project/go-hamt-ipld#59 added some tests, and although they are very go dependant, there may be a way to verify against.
I might end up taking this, but if someone else does, ping me and I can give more info or a plan to get this done.
Other information and links
The text was updated successfully, but these errors were encountered:
Issue summary
Equivalent of changes done in #716, a cache for link nodes needs to be added to avoid unnecessary blockstore reads, and along with this change expand the serialization tests to also check the blockstore read and write status with the tracking blockstore added in that PR. Reason this is necessary is because the VM charges gas for every read as well as number of bytes written and number of writes to the blockstore. Without the cache, it will be a mismatch.
With this change, the interface can be changed to return a reference to the element on gets, so try to match the
HashMap
interface. Only difference really is just that the get value is owned (because it currently needs to be) but would be more efficient if this were not the case.Also verify cases like: filecoin-project/go-hamt-ipld#65 as I don't think we reorder on child clean (but not sure if we would run into this bug).
Also with this, try to port over as many tests from the go implementation to verify compatibility, for example filecoin-project/go-hamt-ipld#59 added some tests, and although they are very go dependant, there may be a way to verify against.
I might end up taking this, but if someone else does, ping me and I can give more info or a plan to get this done.
Other information and links
The text was updated successfully, but these errors were encountered: