Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving types for actors into a different crate #788

Closed
amerameen opened this issue Oct 26, 2020 · 0 comments · Fixed by #790
Closed

Moving types for actors into a different crate #788

amerameen opened this issue Oct 26, 2020 · 0 comments · Fixed by #790
Assignees
@austinabell
Labels
Maintenance Priority: 3 - Medium Nice-to-have, does not impede core functionality

Comments

@amerameen
Copy link
Contributor

amerameen commented Oct 26, 2020 •
edited
Loading

Issue summary

This is to facilitate the upgrade to actors v2, while still supporting v1 in the future. Need to look into actors v2 to determine what types are shared. All types within actors that are shared between v1 and v2 must be moved into it's own crate.

Other information and links
@amerameen amerameen added the Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee label Oct 26, 2020
@austinabell austinabell added Priority: 3 - Medium Nice-to-have, does not impede core functionality Maintenance and removed Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee labels Oct 26, 2020
@austinabell austinabell mentioned this issue Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austinabell austinabell

Labels
Maintenance Priority: 3 - Medium Nice-to-have, does not impede core functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor types out of actors crate to prep for v2 upgrade ChainSafe/forest
2 participants
@amerameen @austinabell