Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from 'Initial Sync' to 'Chain Follow' #876

Closed
amerameen opened this issue Nov 30, 2020 · 0 comments · Fixed by #914
Closed

Transition from 'Initial Sync' to 'Chain Follow' #876

amerameen opened this issue Nov 30, 2020 · 0 comments · Fixed by #914
Assignees
Labels
Priority: 2 - High Very important and should be addressed ASAP

Comments

@amerameen
Copy link
Contributor

amerameen commented Nov 30, 2020

Acceptance Criteria

  • Once 'initial sync' is done, switch the ChainSync state to ChainFollow, which will allow pubsub messages to be processed from the network event channel

Questions

  • How do we know when intial sync is done? May be worthwhile looking into how Lotus does it.
  • Do we need to do another 'Initial Sync' after the first one is done (since it takes a while) before switching 'ChainFollow'?
  • The whole time we're doing 'Initial Sync' we're getting gossipsub blocks, what is happening to these? What do we do with them once we switch to 'ChainFollow'?
  • How to test this properly? May be difficult
  • Signalling to the ChainSyncer that 'Initial Sync' is done is not trivial.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 - High Very important and should be addressed ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants