Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Test TestChainRPC #3041

Closed
EclesioMeloJunior opened this issue Jan 12, 2023 · 1 comment · Fixed by #3042
Closed

Fix Flaky Test TestChainRPC #3041

EclesioMeloJunior opened this issue Jan 12, 2023 · 1 comment · Fixed by #3042
Assignees

Comments

@EclesioMeloJunior
Copy link
Member

EclesioMeloJunior commented Jan 12, 2023

Description

The test TestChainRPC waits for a block with a number greater than 0 or 1 to be finalized. When the block is finalized this test calls the chain_getBlock RPC endpoint to retrieve the full block header and calls chain_getBlock again but this time to retrieve the parent block full header.

The last step in the test is to call chain_getBlockHash and assert that the returned hash is not equal to the finalized hash retrieved in the very first step, this last part is flaky since it is not guaranteed that when we call chain_getBlockHash a new block ahead of the finalized one was produced

Copy link

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant