Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single flag for log-level in the CLI #3210

Closed
kanishkatn opened this issue Apr 17, 2023 · 2 comments · Fixed by #3303
Closed

Use a single flag for log-level in the CLI #3210

kanishkatn opened this issue Apr 17, 2023 · 2 comments · Fixed by #3303
Assignees

Comments

@kanishkatn
Copy link
Contributor

Issue summary

Currently, we have several flags to set the log-level of the modules.

  • --log to set the global log-level
  • Module specific flags (--lcore, --lrpc etc) to set the module log-level

We could use a single flag to accept all the log-levels. For example:
--log global:info, core:debug, rpc:crit

Other information and links

This was noticed during the CLI refactor (#3173) and was decided to pick it up at a later stage

Discussion around the CLI refactor: #3171
CLI refactor main issue: #3163

@danforbes
Copy link
Contributor

Can we make sure that there's an easy way for users to discover all the modules that are available for log-level tuning? It seems like this information will be present in the config file, which is honestly probably all that's necessary. It would also be nice, though, if this was listed clearly in the --help message.

Copy link

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants