fix(dot): use tempDir in tests as base path to avoid creating `dot/~` #3363

kishansagathiya · 2023-06-29T11:38:20Z

Changes

When you run integration tests in for dot say go test -tags integration --run github.com/ChainSafe/gossamer/dot/... -v, a folder named dot/~ gets created.

We shouldn't create a folder named ~ and use home.

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Primary Reviewer

@EclesioMeloJunior

codecov · 2023-06-29T12:23:58Z

Codecov Report

Merging #3363 (35fc80b) into development (ac52090) will decrease coverage by 0.32%.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #3363      +/-   ##
===============================================
- Coverage        51.54%   51.23%   -0.32%     
===============================================
  Files              225      225              
  Lines            28117    28117              
===============================================
- Hits             14493    14405      -88     
- Misses           12239    12327      +88     
  Partials          1385     1385

jimjbrettj

Maybe I am not running the correct thing, but I don't seem to replicate this behavior. Where is the "dot" prefix coming from? I don't see it in the changes. Perhaps I'm missing something, but for me $HOME is the same as ~ so this PR doesn't appear to change much except for where we define the basepath

dimartiro · 2023-06-30T21:26:38Z

Maybe I am not running the correct thing, but I don't seem to replicate this behavior. Where is the "dot" prefix coming from? I don't see it in the changes. Perhaps I'm missing something, but for me $HOME is the same as ~ so this PR doesn't appear to change much except for where we define the basepath

Same here
~ actually means "home" in linux like systems (try cd ~ for example) so I don't think if we really need this change

kishansagathiya · 2023-07-02T08:23:26Z

Maybe I am not running the correct thing, but I don't seem to replicate this behavior. Where is the "dot" prefix coming from? I don't see it in the changes. Perhaps I'm missing something, but for me $HOME is the same as ~ so this PR doesn't appear to change much except for where we define the basepath

@jimjbrettj @dimartiro
Inside development branch, can none of you see a filder named ~ created in the dot folder on running the command below?

go clean -testcache
go test -tags integration github.com/ChainSafe/gossamer/dot

This is what I am talking about,

dimartiro · 2023-07-03T01:19:16Z

@kishansagathiya you are right! I misunderstood the folder location.
Yes! I'm having the same issue, thanks for clarify

I ran the test and this folder was created.

Thanks for taking the issue and sorry for the misunderstood 🙏

kanishkatn

Correct me if I'm wrong, this is already being handled at https://github.com/ChainSafe/gossamer/blob/development/cmd/gossamer/commands/utils.go#L308. Not all integration tests create the folder in the project path.

I feel we need to identify which test is creating this and look into resolving it instead of changing the default config. Because, if there is an issue with the base-path resolution, it could affect the normal run as well since it accepts the same format.

kishansagathiya · 2023-07-03T11:54:37Z

From what I understand ~ is a shell concept. Shell will understand the meaning of ~, but go won't. https://go.dev/play/p/3Az7NSMMPFk

Sure, we can use ExpandDir, but that should happen first time that path is getting set. The approach of finding where a particular path is being used and using ExpandDir there, seems wrong to me. That way will have to use ExpandDir for all paths or trace where a path with ~ could be used and use ExpandDir there.

We could have something like this.

defaultBasePath = "~/.gossamer/polkadot"
config.BasePath = ExpandDir(defaultBasePath)

But even in this defaultBasePath is an inappropriate path, since we would never want anyone to use it directly.

My preference is the code i submitted. The perfect use of ExpandDir would be to expand a user submitted path, like --path=~/.gossamer

kanishkatn · 2023-07-03T12:00:29Z

The perfect use of ExpandDir would be to expand a user submitted path, like --path=~/.gossamer

You're absolutely right and that's exactly how it is designed right now.

Sure, we can use ExpandDir, but that should happen first time that path is getting set.

The default config is just a helper module and it isn't where the path is being set. It is happening in the function that I shared above. There are quite a bit of abstraction in the CLI package and I'd be happy to walk you through it to explain it better over a call.

kishansagathiya · 2023-07-03T12:38:25Z

defaultBasePath = "~/.gossamer/polkadot"
config.BasePath = ExpandDir(defaultBasePath)

What's wrong with this ?

currently we have something like,

defaultBasePath = "~/.gossamer/polkadot"
config.BasePath = defaultBasePath

base path with ~ in it is just wrong. Expanding it later, it fixing the mistake.

I feel we need to identify which test is creating this and look into resolving it

That would be a hack. The primary problem is that our base path in our default config is not usable.

kanishkatn · 2023-07-03T13:19:36Z

What's wrong with this ?

Sure, let me try to explain it here itself. As mentioned in the above comment #3363 (review), the base-path parsing is already being handled in parseBasePath() method and there is no need to include it in default config.

The parseBaseConfig() method resolves the relative path regardless of where it is being set ( env, default config, flags or the config file ).

base path with ~ in it is just wrong. Expanding it later, it fixing the mistake.

It's a feature, not a bug and it has been inherited from the previous cli. The feature being the ability to resolve the relative paths.

That would be a hack. The primary problem is that our base path in our default config is not usable.

I disagree since the issue we're trying to solve is one of the test messing up the base-path somehow ( see my above two responses in this comment for the explanation ). The base-path in the default config is usable and it works fine otherwise.

Again, happy to go over this on a call!

kishansagathiya · 2023-07-04T06:24:51Z

I don't think you are trying to understand what I am arguing.

My main point is that there is no reason to have a path in our code base with ~ in it. And so far, you have not given me any reasoning to keep it.

the base-path parsing is already being handled in parseBasePath()

You don't need to parse config.BasePath, if you set the right path.

I get it that there is parseBasePath and bunch of other functions. But those functions are to re-populate config with with say flags, env, etc. It doesn't explain why we need to have defaultBasePath = "~/.gossamer/kusama"

It's a feature, not a bug and it has been inherited from the previous cli. The feature being the ability to resolve the relative paths.

Have ability to use relative paths. But don't put a path with ~ if we can do without it. I am arguing about removing ~ from defaultBasePath = "~/.gossamer/kusama". That ~ has no feature.

kishansagathiya · 2023-07-04T08:28:01Z

We have had a call. @kanishkatn pointed out that we shouldn't be using home directory anyway for tests and should be using temp dir.

I am going to edit all the tests that use DefaultConfig() to use TempDir, instead of using the default base path. I will revert the changes to the basepath in this PR and just make sure that we don't use default base path directly in tests.

kishansagathiya · 2023-07-04T11:12:54Z

@EclesioMeloJunior @dimartiro Have changed this PR quite a bit. Feel free to re-review this.

kanishkatn · 2023-07-04T11:17:12Z

Thank you for fixing the tests @kishansagathiya . It seems like I missed out on this during the refactor.

If you still have concern regarding the use of relative paths in the default config or anywhere else, please create an issue.

It would be nice to create an issue before raising a PR to avoid these kinda confusion in the future!

kanishkatn

I thought I approved it, my bad.

… kishan/fix/tilde

# [0.8.0](v0.7.0...v0.8.0) (2023-12-11) ### Bug Fixes * **.github/workflows:** update node.js version ([#3637](#3637)) ([619be1b](619be1b)) * **babe:** Add support for versioned NextConfigData decoding ([#3239](#3239)) ([5ee3a64](5ee3a64)) * **blockstate:** if blocktree fails to search a hash in memory, load it from disk ([#3059](#3059)) ([6442544](6442544)) * cache slot to header data while checking BABE equivocation ([#3364](#3364)) ([dcfa4a4](dcfa4a4)) * **chain:** Fix `chain=westend` option ([#3123](#3123)) ([64dbba6](64dbba6)) * **ci:** cancel previous workflow runs ([#3140](#3140)) ([a322a19](a322a19)) * **ci:** fix all Deepsource issues ([#3046](#3046)) ([4ea0a70](4ea0a70)) * **ci:** fix broken docker build ([#3231](#3231)) ([f796430](f796430)) * **ci:** Fix staging metrics collection ([#3138](#3138)) ([05a5c4c](05a5c4c)) * **cli:** parse module log-levels ([#3285](#3285)) ([86c7577](86c7577)) * **cmd/gossamer:** embed default toml config files ([#3091](#3091)) ([af38364](af38364)) * **cmd/gossamer:** update error message ([#3301](#3301)) ([960a9d4](960a9d4)) * **dot/babe:** use `bs.latestFinalised` instead of using `round/set id` ([#3167](#3167)) ([46c0ef7](46c0ef7)) * **dot/digest:** create `BlockImportHandler` and remove channel ([#3312](#3312)) ([a179855](a179855)) * **dot/network:** `findPeers` returns on timeout if a peer is found ([#3001](#3001)) ([2a05ce7](2a05ce7)) * **dot/network:** remove `maxReads` limitation to read stream ([#3287](#3287)) ([483b23f](483b23f)) * **dot/state:** clean up scheduled changes once a forced change is applied ([#3219](#3219)) ([5ebec46](5ebec46)) * **dot/state:** fix a bug in IsDescendantOf ([#3125](#3125)) ([4fd4a89](4fd4a89)) * **dot/state:** store raw authority keys and decode when verifying block signature ([#3627](#3627)) ([58f741d](58f741d)) * **dot/sync:** fix `Timestamp slot must match 'CurrentSlot'` while using `westend` spec file ([#3040](#3040)) ([e6da01b](e6da01b)) * **dot/sync:** Revert verify justification before importing blocks ([#3615](#3615)) ([11b96dc](11b96dc)) * **dot/sync:** rework on bootstrap/tip sync ([#3227](#3227)) ([ab6650a](ab6650a)) * **dot/sync:** use `Range` instead of `SubChain` at `handleDescedingRequest` ([#3006](#3006)) ([a83c1a3](a83c1a3)) * **dot/sync:** verify justification before importing blocks ([#3576](#3576)) ([2954fc0](2954fc0)) * **dot/sync:** wrong error message at `checkOrGetDescendantHash` ([#2971](#2971)) ([b1c6bf1](b1c6bf1)) * **dot:** use tempDir in tests as base path to avoid creating `dot/~` ([#3363](#3363)) ([04514d5](04514d5)) * **go.mod:** Replace `centrifuge/go-substrate-rpc-client` dependency to `timwu20/go-substrate-rpc-client` temporarily to fix build ([#3572](#3572)) ([ea49251](ea49251)) * **lib/babe:** Add context and additional assertion to TestBuildBlock_ok ([#3101](#3101)) ([a9a89ed](a9a89ed)) * **lib/babe:** rewrite TestBuildBlock_failing ([#3089](#3089)) ([28a3d0b](28a3d0b)) * **lib/babe:** use current system time to yield a new slot ([#3133](#3133)) ([9cd6f25](9cd6f25)) * **lib/grandpa:** on verifying block justification, compare given block hash with finalised hash ([#3081](#3081)) ([fc91843](fc91843)) * **lib/grandpa:** ensure `finalisationEngine` exits when stop channel is triggered ([#3141](#3141)) ([d7f7c06](d7f7c06)) * **lib/runtime:** `ext_default_child_storage_next_key_version_1` return `None` correctly ([#3473](#3473)) ([c7d574b](c7d574b)) * **lib/runtime:** Fix `wasm error: out of bounds memory access` at `[#9412261](https://github.com/ChainSafe/gossamer/issues/9412261)` ([#3588](#3588)) ([ecb1ad9](ecb1ad9)) * **lib/runtime:** prevents polkadot zero-address bug using `sr25519_verify` version 1 ([#3494](#3494)) ([8b93d5e](8b93d5e)) * **lib/runtime:** return correct encoded value for `None` ([#3451](#3451)) ([3e11bc2](3e11bc2)) * **lib/runtime:** update `MaxPossibleAllocation` to `2^25` ([#3393](#3393)) ([91eabdc](91eabdc)) * **lib/runtime:** use `westend-dev` spec file in `TestNodeRuntime_ValidateTransaction` ([#3047](#3047)) ([043f5eb](043f5eb)) * **lib/trie:** `ClearFromChild` should update parent trie ([#3482](#3482)) ([70e2d2b](70e2d2b)) * **lib/trie:** create an empty child trie if not found ([#3459](#3459)) ([5d68447](5d68447)) * **lib/trie:** record deleted Merkle values fixed ([#2873](#2873)) ([61f0216](61f0216)) * **peerset:** check for incoming slot error ([#2952](#2952)) ([a1602bc](a1602bc)) * **rpc-tests:** Fix node port to execute tests on macOS ([#3223](#3223)) ([f758575](f758575)) * **rpc/modules:** use `westend-local` in `TestAuthorModule_SubmitExtrinsic_invalid` test ([#3051](#3051)) ([b6429b7](b6429b7)) * **runtime:** initialize TransactionState when creating runtime instance ([#3188](#3188)) ([29fe7a0](29fe7a0)) * **scale:** Use *int for scale index ([#3274](#3274)) ([9b04d30](9b04d30)) * **staging:** fixes the staging deployment issues caused by the new cli ([#3266](#3266)) ([1f4e786](1f4e786)) * **state:** clarify node hashes vs merkle values ([#2915](#2915)) ([e4033e8](e4033e8)) * **test/rpc:** use `westend-local` in `TestStateRPCAPI` ([#3049](#3049)) ([c57ade6](c57ade6)) * **tests/polkadot_js:** Use `westend-local` to run polkadot js test suite ([#3052](#3052)) ([2d5ead1](2d5ead1)) * **tests/rpc:** ensure new blocks are created before assert ([#3042](#3042)) ([a116d58](a116d58)) * **tests/rpc:** flaky test `TestChainSubscriptionRPC/chain_subscribeNewHeads` ([#3092](#3092)) ([5b56238](5b56238)) * **tests/rpc:** place `GreaterOrEqual` arguments in the correct order at `chain_subscribeNewHeads` test ([#3137](#3137)) ([33bdf28](33bdf28)) * **tests:** Export unimplemented runtime fuctions ([#3461](#3461)) ([3e4546c](3e4546c)) * **trie:** do not create buffer for nil child ([#2928](#2928)) ([d70af4f](d70af4f)) * **wasmer:** `ext_storage_exists_version_1` for empty values ([#2973](#2973)) ([059268e](059268e)) ### Features * **chain:** Add Westend network as command line `chain` option ([#3103](#3103)) ([d9cdd45](d9cdd45)) * **chain:** remove unneeded spec files ([#3086](#3086)) ([c76387d](c76387d)) * **cli:** use a single flag for log level in the CLI ([#3303](#3303)) ([caf3ea4](caf3ea4)) * **dot/network:** introduce libp2p resource manager + prometheus metrics ([#3333](#3333)) ([f166746](f166746)) * **dot/rpc:** export block trie state entries for a block hash ([#3607](#3607)) ([43828fe](43828fe)) * **dot/rpc:** implement RPC method state_queryStorageAt ([#3191](#3191)) ([3bbdfe0](3bbdfe0)) * **dot/state:** create `Range` to traverse the blocktree and the blocks in the disk ([#2990](#2990)) ([4442eee](4442eee)) * **dot/state:** keep latest state trie in memory ([#3386](#3386)) ([421d087](421d087)) * **dot/sync:** include block origin and skip extra validation on `initialSync` ([#3392](#3392)) ([8e1650e](8e1650e)) * **dot/sync:** Remove the `EndBlockHash` from `BlockRequestMessage` ([#2977](#2977)) ([b25e0b4](b25e0b4)) * **internal/database:** replace `chaindb/badgerdb` with `pebbledb` ([#3434](#3434)) ([344461d](344461d)) * introduces `SaturatingAdd` and `SaturatingSub` ([#3519](#3519)) ([daa9e25](daa9e25)) * **lib/allocator:** Refactor `FreeingBumpHeapAllocator` ([#3570](#3570)) ([39ca47f](39ca47f)) * **lib/babe:** Submit BABE equivocation report ([#2947](#2947)) ([55de62e](55de62e)), closes [#2853](#2853) * **lib/blocktree:** reduce the entries in the runtimes mapping ([#3151](#3151)) ([1a34972](1a34972)) * **lib/grandpa:** include `t.Parallel()` to all `lib/grandpa` tests ([#2840](#2840)) ([5c93488](5c93488)) * **lib/runtime/wasmer:** report grandpa equivocations ([#3007](#3007)) ([e63aeea](e63aeea)) * **lib/runtime:** `wazero` implementation of `runtime.Instance` ([#3279](#3279)) ([115d6f5](115d6f5)) * **lib/runtime:** add extra required runtime imports for parachain validation ([#3254](#3254)) ([dc1a521](dc1a521)) * **lib/runtime:** Update default `runtime.Instance` to `wazero` ([#3352](#3352)) ([308b10a](308b10a)) * **pkg/scale:** `VaryingDataType` String method ([#2970](#2970)) ([841636e](841636e)) * **pkg/scale:** Add `Marshaler` and `Unmarshaler` interfaces and functionality ([#3617](#3617)) ([4888ce4](4888ce4)) * **pkg/scale:** Use `New()` receiver function for construction of custom `VaryingDataType` ([#3315](#3315)) ([9688f6c](9688f6c)) * **runtime/wasmer:** create wrapper around wasmer.Memory ([#3160](#3160)) ([fc1055d](fc1055d)) * **runtime/wasmer:** write wasmer using latest wasmer version ([#3168](#3168)) ([32f1aa8](32f1aa8)) * **scale:** add `MustMarshal` function ([#2991](#2991)) ([32a80aa](32a80aa)) * **sync:** Validate bad blocks ([#3220](#3220)) ([0d0354b](0d0354b)) * **telemetry:** Add scheduled and force changes telemetry metrics ([#3226](#3226)) ([c53b1cd](c53b1cd)) * **trie:** Add trie v1 new headers support ([#3295](#3295)) ([c30f463](c30f463)) * **zombienet:** Add javascript tests to zombienet testing ([#3200](#3200)) ([aca9a5b](aca9a5b)) * **zombienet:** add zombienet testing to github workflow ([#3192](#3192)) ([d788bd6](d788bd6)) ### Reverts * **lib/runtime:** rollback wasmer update `PR[#3168](https://github.com/ChainSafe/gossamer/issues/3168)` ([#3264](#3264)) ([e7ff0cf](e7ff0cf))

github-actions · 2023-12-11T22:18:21Z

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [0.8.0](v0.7.0...v0.8.0) (2023-12-11) ### Bug Fixes * **.github/workflows:** update node.js version ([#3637](#3637)) ([619be1b](619be1b)) * **babe:** Add support for versioned NextConfigData decoding ([#3239](#3239)) ([5ee3a64](5ee3a64)) * **blockstate:** if blocktree fails to search a hash in memory, load it from disk ([#3059](#3059)) ([6442544](6442544)) * cache slot to header data while checking BABE equivocation ([#3364](#3364)) ([dcfa4a4](dcfa4a4)) * **chain:** Fix `chain=westend` option ([#3123](#3123)) ([64dbba6](64dbba6)) * **ci:** cancel previous workflow runs ([#3140](#3140)) ([a322a19](a322a19)) * **ci:** fix all Deepsource issues ([#3046](#3046)) ([4ea0a70](4ea0a70)) * **ci:** fix broken docker build ([#3231](#3231)) ([f796430](f796430)) * **ci:** Fix staging metrics collection ([#3138](#3138)) ([05a5c4c](05a5c4c)) * **cli:** parse module log-levels ([#3285](#3285)) ([86c7577](86c7577)) * **cmd/gossamer:** embed default toml config files ([#3091](#3091)) ([af38364](af38364)) * **cmd/gossamer:** update error message ([#3301](#3301)) ([960a9d4](960a9d4)) * **dot/babe:** use `bs.latestFinalised` instead of using `round/set id` ([#3167](#3167)) ([46c0ef7](46c0ef7)) * **dot/digest:** create `BlockImportHandler` and remove channel ([#3312](#3312)) ([a179855](a179855)) * **dot/network:** `findPeers` returns on timeout if a peer is found ([#3001](#3001)) ([2a05ce7](2a05ce7)) * **dot/network:** remove `maxReads` limitation to read stream ([#3287](#3287)) ([483b23f](483b23f)) * **dot/state:** clean up scheduled changes once a forced change is applied ([#3219](#3219)) ([5ebec46](5ebec46)) * **dot/state:** fix a bug in IsDescendantOf ([#3125](#3125)) ([4fd4a89](4fd4a89)) * **dot/state:** store raw authority keys and decode when verifying block signature ([#3627](#3627)) ([58f741d](58f741d)) * **dot/sync:** fix `Timestamp slot must match 'CurrentSlot'` while using `westend` spec file ([#3040](#3040)) ([e6da01b](e6da01b)) * **dot/sync:** Revert verify justification before importing blocks ([#3615](#3615)) ([11b96dc](11b96dc)) * **dot/sync:** rework on bootstrap/tip sync ([#3227](#3227)) ([ab6650a](ab6650a)) * **dot/sync:** use `Range` instead of `SubChain` at `handleDescedingRequest` ([#3006](#3006)) ([a83c1a3](a83c1a3)) * **dot/sync:** verify justification before importing blocks ([#3576](#3576)) ([2954fc0](2954fc0)) * **dot/sync:** wrong error message at `checkOrGetDescendantHash` ([#2971](#2971)) ([b1c6bf1](b1c6bf1)) * **dot:** use tempDir in tests as base path to avoid creating `dot/~` ([#3363](#3363)) ([04514d5](04514d5)) * **go.mod:** Replace `centrifuge/go-substrate-rpc-client` dependency to `timwu20/go-substrate-rpc-client` temporarily to fix build ([#3572](#3572)) ([ea49251](ea49251)) * **lib/babe:** Add context and additional assertion to TestBuildBlock_ok ([#3101](#3101)) ([a9a89ed](a9a89ed)) * **lib/babe:** rewrite TestBuildBlock_failing ([#3089](#3089)) ([28a3d0b](28a3d0b)) * **lib/babe:** use current system time to yield a new slot ([#3133](#3133)) ([9cd6f25](9cd6f25)) * **lib/grandpa:** on verifying block justification, compare given block hash with finalised hash ([#3081](#3081)) ([fc91843](fc91843)) * **lib/grandpa:** ensure `finalisationEngine` exits when stop channel is triggered ([#3141](#3141)) ([d7f7c06](d7f7c06)) * **lib/runtime:** `ext_default_child_storage_next_key_version_1` return `None` correctly ([#3473](#3473)) ([c7d574b](c7d574b)) * **lib/runtime:** Fix `wasm error: out of bounds memory access` at `[#9412261](https://github.com/ChainSafe/gossamer/issues/9412261)` ([#3588](#3588)) ([ecb1ad9](ecb1ad9)) * **lib/runtime:** prevents polkadot zero-address bug using `sr25519_verify` version 1 ([#3494](#3494)) ([8b93d5e](8b93d5e)) * **lib/runtime:** return correct encoded value for `None` ([#3451](#3451)) ([3e11bc2](3e11bc2)) * **lib/runtime:** update `MaxPossibleAllocation` to `2^25` ([#3393](#3393)) ([91eabdc](91eabdc)) * **lib/runtime:** use `westend-dev` spec file in `TestNodeRuntime_ValidateTransaction` ([#3047](#3047)) ([043f5eb](043f5eb)) * **lib/trie:** `ClearFromChild` should update parent trie ([#3482](#3482)) ([70e2d2b](70e2d2b)) * **lib/trie:** create an empty child trie if not found ([#3459](#3459)) ([5d68447](5d68447)) * **lib/trie:** record deleted Merkle values fixed ([#2873](#2873)) ([61f0216](61f0216)) * **peerset:** check for incoming slot error ([#2952](#2952)) ([a1602bc](a1602bc)) * **rpc-tests:** Fix node port to execute tests on macOS ([#3223](#3223)) ([f758575](f758575)) * **rpc/modules:** use `westend-local` in `TestAuthorModule_SubmitExtrinsic_invalid` test ([#3051](#3051)) ([b6429b7](b6429b7)) * **runtime:** initialize TransactionState when creating runtime instance ([#3188](#3188)) ([29fe7a0](29fe7a0)) * **scale:** Use *int for scale index ([#3274](#3274)) ([9b04d30](9b04d30)) * **staging:** fixes the staging deployment issues caused by the new cli ([#3266](#3266)) ([1f4e786](1f4e786)) * **state:** clarify node hashes vs merkle values ([#2915](#2915)) ([e4033e8](e4033e8)) * **test/rpc:** use `westend-local` in `TestStateRPCAPI` ([#3049](#3049)) ([c57ade6](c57ade6)) * **tests/polkadot_js:** Use `westend-local` to run polkadot js test suite ([#3052](#3052)) ([2d5ead1](2d5ead1)) * **tests/rpc:** ensure new blocks are created before assert ([#3042](#3042)) ([a116d58](a116d58)) * **tests/rpc:** flaky test `TestChainSubscriptionRPC/chain_subscribeNewHeads` ([#3092](#3092)) ([5b56238](5b56238)) * **tests/rpc:** place `GreaterOrEqual` arguments in the correct order at `chain_subscribeNewHeads` test ([#3137](#3137)) ([33bdf28](33bdf28)) * **tests:** Export unimplemented runtime fuctions ([#3461](#3461)) ([3e4546c](3e4546c)) * **trie:** do not create buffer for nil child ([#2928](#2928)) ([d70af4f](d70af4f)) * **wasmer:** `ext_storage_exists_version_1` for empty values ([#2973](#2973)) ([059268e](059268e)) ### Features * **chain:** Add Westend network as command line `chain` option ([#3103](#3103)) ([d9cdd45](d9cdd45)) * **chain:** remove unneeded spec files ([#3086](#3086)) ([c76387d](c76387d)) * **cli:** use a single flag for log level in the CLI ([#3303](#3303)) ([caf3ea4](caf3ea4)) * **dot/network:** introduce libp2p resource manager + prometheus metrics ([#3333](#3333)) ([f166746](f166746)) * **dot/rpc:** export block trie state entries for a block hash ([#3607](#3607)) ([43828fe](43828fe)) * **dot/rpc:** implement RPC method state_queryStorageAt ([#3191](#3191)) ([3bbdfe0](3bbdfe0)) * **dot/state:** create `Range` to traverse the blocktree and the blocks in the disk ([#2990](#2990)) ([4442eee](4442eee)) * **dot/state:** keep latest state trie in memory ([#3386](#3386)) ([421d087](421d087)) * **dot/sync:** include block origin and skip extra validation on `initialSync` ([#3392](#3392)) ([8e1650e](8e1650e)) * **dot/sync:** Remove the `EndBlockHash` from `BlockRequestMessage` ([#2977](#2977)) ([b25e0b4](b25e0b4)) * **internal/database:** replace `chaindb/badgerdb` with `pebbledb` ([#3434](#3434)) ([344461d](344461d)) * introduces `SaturatingAdd` and `SaturatingSub` ([#3519](#3519)) ([daa9e25](daa9e25)) * **lib/allocator:** Refactor `FreeingBumpHeapAllocator` ([#3570](#3570)) ([39ca47f](39ca47f)) * **lib/babe:** Submit BABE equivocation report ([#2947](#2947)) ([55de62e](55de62e)), closes [#2853](#2853) * **lib/blocktree:** reduce the entries in the runtimes mapping ([#3151](#3151)) ([1a34972](1a34972)) * **lib/grandpa:** include `t.Parallel()` to all `lib/grandpa` tests ([#2840](#2840)) ([5c93488](5c93488)) * **lib/runtime/wasmer:** report grandpa equivocations ([#3007](#3007)) ([e63aeea](e63aeea)) * **lib/runtime:** `wazero` implementation of `runtime.Instance` ([#3279](#3279)) ([115d6f5](115d6f5)) * **lib/runtime:** add extra required runtime imports for parachain validation ([#3254](#3254)) ([dc1a521](dc1a521)) * **lib/runtime:** Update default `runtime.Instance` to `wazero` ([#3352](#3352)) ([308b10a](308b10a)) * **pkg/scale:** `VaryingDataType` String method ([#2970](#2970)) ([841636e](841636e)) * **pkg/scale:** Add `Marshaler` and `Unmarshaler` interfaces and functionality ([#3617](#3617)) ([4888ce4](4888ce4)) * **pkg/scale:** Use `New()` receiver function for construction of custom `VaryingDataType` ([#3315](#3315)) ([9688f6c](9688f6c)) * **runtime/wasmer:** create wrapper around wasmer.Memory ([#3160](#3160)) ([fc1055d](fc1055d)) * **runtime/wasmer:** write wasmer using latest wasmer version ([#3168](#3168)) ([32f1aa8](32f1aa8)) * **scale:** add `MustMarshal` function ([#2991](#2991)) ([32a80aa](32a80aa)) * **sync:** Validate bad blocks ([#3220](#3220)) ([0d0354b](0d0354b)) * **telemetry:** Add scheduled and force changes telemetry metrics ([#3226](#3226)) ([c53b1cd](c53b1cd)) * **trie:** Add trie v1 new headers support ([#3295](#3295)) ([c30f463](c30f463)) * **zombienet:** Add javascript tests to zombienet testing ([#3200](#3200)) ([aca9a5b](aca9a5b)) * **zombienet:** add zombienet testing to github workflow ([#3192](#3192)) ([d788bd6](d788bd6)) ### Reverts * **lib/runtime:** rollback wasmer update `PR[#3168](https://github.com/ChainSafe/gossamer/issues/3168)` ([#3264](#3264)) ([e7ff0cf](e7ff0cf))

kishansagathiya requested review from edwardmack, timwu20, EclesioMeloJunior, jimjbrettj, dimartiro and kanishkatn as code owners June 29, 2023 11:38

kishansagathiya marked this pull request as draft June 29, 2023 11:38

kishansagathiya marked this pull request as ready for review June 29, 2023 12:36

EclesioMeloJunior approved these changes Jun 29, 2023

View reviewed changes

jimjbrettj reviewed Jun 29, 2023

View reviewed changes

dimartiro approved these changes Jul 3, 2023

View reviewed changes

kanishkatn suggested changes Jul 3, 2023

View reviewed changes

kishansagathiya requested a review from jimjbrettj July 3, 2023 12:38

kishansagathiya force-pushed the kishan/fix/tilde branch from 0f79424 to 8ffb96f Compare July 4, 2023 11:08

kishansagathiya changed the title ~~fix(dot): use home folder instead of dot/~~~ fix(dot): use tempDir in tests as base path to avoid creating dot/~ Jul 4, 2023

Use TempDir instead of home dir in tests

c102b71

kishansagathiya force-pushed the kishan/fix/tilde branch from 8ffb96f to c102b71 Compare July 4, 2023 11:11

EclesioMeloJunior approved these changes Jul 4, 2023

View reviewed changes

kishansagathiya requested a review from kanishkatn July 4, 2023 14:28

dimartiro approved these changes Jul 4, 2023

View reviewed changes

kanishkatn approved these changes Jul 4, 2023

View reviewed changes

kishansagathiya added 4 commits July 5, 2023 01:44

Merge branch 'development' into kishan/fix/tilde

b693a36

Merge branch 'development' into kishan/fix/tilde

3c5d2a3

fixing one more test

d338bf7

Merge branch 'kishan/fix/tilde' of github.com:ChainSafe/gossamer into…

35fc80b

… kishan/fix/tilde

kishansagathiya merged commit 04514d5 into development Jul 4, 2023

kishansagathiya deleted the kishan/fix/tilde branch July 4, 2023 21:29

github-actions bot added the released label Dec 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dot): use tempDir in tests as base path to avoid creating `dot/~` #3363

fix(dot): use tempDir in tests as base path to avoid creating `dot/~` #3363

kishansagathiya commented Jun 29, 2023

codecov bot commented Jun 29, 2023 •

edited

Loading

jimjbrettj left a comment •

edited

Loading

dimartiro commented Jun 30, 2023 •

edited

Loading

kishansagathiya commented Jul 2, 2023 •

edited

Loading

dimartiro commented Jul 3, 2023

kanishkatn left a comment •

edited

Loading

kishansagathiya commented Jul 3, 2023

kanishkatn commented Jul 3, 2023

kishansagathiya commented Jul 3, 2023

kanishkatn commented Jul 3, 2023 •

edited

Loading

kishansagathiya commented Jul 4, 2023 •

edited

Loading

kishansagathiya commented Jul 4, 2023 •

edited

Loading

kishansagathiya commented Jul 4, 2023

kanishkatn commented Jul 4, 2023

kanishkatn left a comment

github-actions bot commented Dec 11, 2023

fix(dot): use tempDir in tests as base path to avoid creating dot/~ #3363

fix(dot): use tempDir in tests as base path to avoid creating dot/~ #3363

Conversation

kishansagathiya commented Jun 29, 2023

Changes

Tests

Issues

Primary Reviewer

codecov bot commented Jun 29, 2023 • edited Loading

Codecov Report

jimjbrettj left a comment • edited Loading

Choose a reason for hiding this comment

dimartiro commented Jun 30, 2023 • edited Loading

kishansagathiya commented Jul 2, 2023 • edited Loading

dimartiro commented Jul 3, 2023

kanishkatn left a comment • edited Loading

Choose a reason for hiding this comment

kishansagathiya commented Jul 3, 2023

kanishkatn commented Jul 3, 2023

kishansagathiya commented Jul 3, 2023

kanishkatn commented Jul 3, 2023 • edited Loading

kishansagathiya commented Jul 4, 2023 • edited Loading

kishansagathiya commented Jul 4, 2023 • edited Loading

kishansagathiya commented Jul 4, 2023

kanishkatn commented Jul 4, 2023

kanishkatn left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 11, 2023

fix(dot): use tempDir in tests as base path to avoid creating `dot/~` #3363

fix(dot): use tempDir in tests as base path to avoid creating `dot/~` #3363

codecov bot commented Jun 29, 2023 •

edited

Loading

jimjbrettj left a comment •

edited

Loading

dimartiro commented Jun 30, 2023 •

edited

Loading

kishansagathiya commented Jul 2, 2023 •

edited

Loading

kanishkatn left a comment •

edited

Loading

kanishkatn commented Jul 3, 2023 •

edited

Loading

kishansagathiya commented Jul 4, 2023 •

edited

Loading

kishansagathiya commented Jul 4, 2023 •

edited

Loading