Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy js files to dist manually #340

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Sep 23, 2022

Description

  • There is build issue
Error: R] No matching export in "dist/src/message/rpc.cjs" for import "default"

    dist/src/message/rpc.js:1:7:
      1 │ import cjs from "./rpc.cjs";
  • root cause is
This file is considered to be an ECMAScript module because of the "export" keyword here:

    dist/src/message/rpc.cjs:1747:0:
      1747 │ export {};

Description
During build process, js files are automatically copied to dist folder and some how it added 1 extra line at the end

export {};

and it made rpc.cjs file an esm module

  • The fix is to copy js files automatically

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Base: 79.72% // Head: 79.95% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (fc928a0) compared to base (8c5627b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   79.72%   79.95%   +0.23%     
==========================================
  Files          44       44              
  Lines       11096    11226     +130     
  Branches     1015     1017       +2     
==========================================
+ Hits         8846     8976     +130     
  Misses       2250     2250              
Impacted Files Coverage Δ
src/message/rpc.cjs 73.26% <0.00%> (+1.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@twoeths twoeths marked this pull request as ready for review September 23, 2022 05:08
@twoeths twoeths requested a review from a team as a code owner September 23, 2022 05:08
@wemeetagain
Copy link
Member

Hopefully we can get rid of this once we migrate to the new protons 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants