-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove unnecessary conversion from Multiaddr to IP #369
Conversation
Good change, here's the event you're looking for: https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interface-peer-store/src/index.ts#L209 |
2817fcb
to
f23795f
Compare
Codecov ReportBase: 83.58% // Head: 83.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 83.58% 83.26% -0.32%
==========================================
Files 47 48 +1
Lines 11771 11779 +8
Branches 1266 1264 -2
==========================================
- Hits 9839 9808 -31
- Misses 1932 1971 +39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
✔️ looks good! Can't approve since it's my PR |
Gossipsub currently polls connection manager frequently to figure what IPs each peer connection has. This is very inneficient and causes performance issues in Lodestar
Instead js-libp2p should follow a similar pattern to rust-libp2p, which injects an
AddressChange
event into protocols. See https://github.com/sigp/rust-libp2p/blob/a3dec471c046127e8e0d88bc89a881affb56a76c/protocols/gossipsub/src/behaviour.rs#L3282@achingbrain is js-libp2p emitting a similar event already? Where could this be added if not?