Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track pruned messages in tracer #384

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Dec 14, 2022

Motivation

  • In lodestar, metrics showed there are broken promises but if messages are delivered, they are always on time, i.e. within gossipsubIWantFollowupMs
  • So I'd like to track messages that are pruned, i.e they're never delivered

Description

  • add and track iwantMessagePruned metric

part of ChainSafe/lodestar#4818

@twoeths twoeths requested a review from a team as a code owner December 14, 2022 04:14
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Base: 83.29% // Head: 83.26% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (2aeccfb) compared to base (23d49be).
Patch coverage: 37.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   83.29%   83.26%   -0.04%     
==========================================
  Files          48       48              
  Lines       11779    11787       +8     
  Branches     1265     1266       +1     
==========================================
+ Hits         9811     9814       +3     
- Misses       1968     1973       +5     
Impacted Files Coverage Δ
src/metrics.ts 21.91% <0.00%> (-0.13%) ⬇️
src/tracer.ts 77.45% <75.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@twoeths twoeths merged commit dbeb879 into master Dec 14, 2022
@twoeths twoeths deleted the tuyen/track-pruned-promises branch December 14, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants