chore: Add prefix in encryptStream #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
changed the title
dapplion
force-pushed
the
dapplion/encryptStreamPrefix
branch
from
646ef3c to
b9568fd
Compare
mpetrunic
reviewed
Oct 24, 2022
| } | ||
|
|
||
| export const uint16BEEncode: LengthEncoderFunction = (value: number) => { | ||
| export const uint16BEEncode = (value: number): Uint8Array => { |
Member
There was a problem hiding this comment.
why is the type changed here?
Contributor
Author
There was a problem hiding this comment.
Because LengthEncoderFunction is typed are returning either Uint8Array or Uint8Array list, requiring extra code downstream to handle both cases.
Member
|
Also there are some lint issues^^ |
wemeetagain
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript abstractions are not free. While using pipe here looks nice, it adds a non-neglible cost allocating Promises for each extra
for await ()iteration.Move code to add prefix into encryptStream. I'll attempt the same for decryptStream but it's a bit more complex so prefer to split in two PRs