Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that roots are not subtrees #2258

Closed
wemeetagain opened this issue Mar 24, 2021 · 0 comments · Fixed by #2292
Closed

Ensure that roots are not subtrees #2258

wemeetagain opened this issue Mar 24, 2021 · 0 comments · Fixed by #2292
Assignees
@wemeetagain

Comments

@wemeetagain
Copy link
Member

wemeetagain commented Mar 24, 2021 •
edited
Loading

Describe the bug

Currently, roots/checkpoints are used and held in a variety of places. We may be unintentionally storing subtrees when the roots/checkpoints are retrieved from a tree-backed object.

See ChainSafe/persistent-merkle-tree#26 for why this is an issue, and remains an issue in Node <v14

Expected behavior

Ensure that roots and checkpoints are always explicitly converted to struct, eg: Uint8Array, by calling valueOf.

Relies on ChainSafe/ssz#82
Also may be implemented in parallel with ChainSafe/ssz#83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wemeetagain wemeetagain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly convert checkpoint subtrees to struct ChainSafe/lodestar
1 participant
@wemeetagain