New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

altair.processAttestation() performance issue #2618

Closed

dapplion opened this issue Jun 2, 2021 · 1 comment · Fixed by #2626

Assignees

Labels

prio-high scope-performance

Contributor

dapplion commented Jun 2, 2021

Describe the bug

altair.processAttestation() calculates the total balance of the validator set for every index of every attestation.

Expected behavior

This part should be optimized, and compute that total balance the least number of times possible.

The text was updated successfully, but these errors were encountered:

dapplion added prio-high scope-performance labels

Contributor

twoeths commented Jun 3, 2021

We don't have to always call getBaseRewards if the participation is good for an epoch (i.e. the participation has timely source + target + head already)
Improve getBaseRewards: getBaseRewardPerIncrement() should be the same for an epoch so it should be cached in EpochContext

twoeths self-assigned this

dapplion mentioned this issue

Impove processAttestation for altair #2626

Merged

twoeths closed this as completed in #2626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment