Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve processAttestation #2748

Closed
twoeths opened this issue Jun 24, 2021 · 1 comment
Closed

Improve processAttestation #2748

twoeths opened this issue Jun 24, 2021 · 1 comment
Assignees
Labels
scope-performance Performance issue and ideas to improve performance.

Comments

@twoeths
Copy link
Contributor

twoeths commented Jun 24, 2021

Describe the bug

One of the most heavy operation from this profile is processAttestation - signature verification, it takes more than 23% of the time
Screen Shot 2021-06-24 at 15 45 55

  1. In some cases when we pass errorred attestations to chain, we make verifySignature as true by default just in the end put these errorred attestations in eventHandlers.onErrorAttestation
  2. In eventHandler when we reprocess attestations from pending blocks or new slots we process attestations separately

Expected behavior

  1. We should make verifySignature as false in scenario 1 above. When we reprocess these errored attestations, we'll verify signatures again anyway
  2. In scenario 2, we want to do signature verification in batch.

0624-prater-full-attestation-subscriptions.cpuprofile.zip

Steps to Reproduce

Sync prater with full attestation subscriptions

@twoeths twoeths self-assigned this Jun 24, 2021
@twoeths twoeths added the scope-performance Performance issue and ideas to improve performance. label Jun 24, 2021
@twoeths
Copy link
Contributor Author

twoeths commented Jul 2, 2021

not an issue anymore with latest gossip attestation update #2760

@twoeths twoeths closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Development

No branches or pull requests

1 participant