Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DB Bucket definitions to consumer packages #2820

Closed
wemeetagain opened this issue Jul 8, 2021 · 2 comments · Fixed by #5560
Closed

Move DB Bucket definitions to consumer packages #2820

wemeetagain opened this issue Jul 8, 2021 · 2 comments · Fixed by #5560
Labels
prio-low This is nice to have.

Comments

@wemeetagain
Copy link
Member

Is your feature request related to a problem? Please describe.

DB Bucket entries are all defined in the db package. Some of these entries are used in the beacon node (lodestar package), some are used in the validator (validator package).
The db package should really only be used to define the abstract db logic, and doesn't need to know which buckets exist for all downstream db consumers.

Describe the solution you'd like

Move bucket entries to the lodestar and validator packages.

Describe alternatives you've considered

Leave as is

Additional context

See https://github.com/ChainSafe/lodestar/blob/master/packages/db/src/schema.ts#L8-L70

@dapplion
Copy link
Contributor

dapplion commented Jul 8, 2021

Sounds good, we can add a test in the lodestar and validator repos to ensure the Buckets don't overlap

@stale
Copy link

stale bot commented Sep 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-low This is nice to have.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants