Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save one validator loop in rotateEpoch #2830

Closed
twoeths opened this issue Jul 11, 2021 · 0 comments · Fixed by #2831
Closed

Save one validator loop in rotateEpoch #2830

twoeths opened this issue Jul 11, 2021 · 0 comments · Fixed by #2831
Assignees
@twoeths
Labels
scope-performance Performance issue and ideas to improve performance.

Comments

@twoeths
Copy link
Contributor

twoeths commented Jul 11, 2021

Is your feature request related to a problem? Please describe.

In Prater, a validator loop in rotateEpoch may take up to 700 ms:

Screen Shot 2021-07-11 at 14 25 00

Describe the solution you'd like

rotateEpoch always run after we process an epoch, which we can extract some validator data from epoch process
@twoeths twoeths self-assigned this Jul 11, 2021
@twoeths twoeths mentioned this issue Jul 11, 2021
Merged
@twoeths twoeths added the scope-performance Performance issue and ideas to improve performance. label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twoeths twoeths

Labels
scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve rotateEpochs and exitQueueEndChurn ChainSafe/lodestar
1 participant
@twoeths