Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lodestar --version should indicate release track #2950

Closed
q9f opened this issue Aug 12, 2021 · 1 comment · Fixed by #2958
Closed

lodestar --version should indicate release track #2950

q9f opened this issue Aug 12, 2021 · 1 comment · Fixed by #2958
Assignees
Labels
prio-medium Resolve this some time soon (tm).

Comments

@q9f
Copy link
Contributor

q9f commented Aug 12, 2021

What is your question?

Given a binary build from latester:

~/lodestar master user@errai
❯ ./packages/cli/bin/lodestar --version
0.28.0

~/lodestar master user@errai
❯ git log -n1 | head -3                
commit 0add9d11d619e8f096d5dbf54ec40a6cf7b14f8f
Author: Lion - dapplion <35266934+dapplion@users.noreply.github.com>
Date:   Wed Aug 11 09:58:29 2021 +0200

Couple of issues:

  • it does not indicate release track (stable/beta/nightly...)
  • it does not indicate code version (git commit, from a release, "dirty"/unstable...)
  • in this case, it provides a wrong version number (because master is already ahead of 0.28.0 right?)

Happy to take this one.

@dapplion
Copy link
Contributor

I agree with the suggestions! We just let yargs cli library handle the version for us. But it's time to print more info. We already do than on the first log line when running the beacon or validator cmds. We could do the same for --version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants