Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fastify to devDependency in lodestar-api #4159

Closed
dapplion opened this issue Jun 14, 2022 · 1 comment · Fixed by #4161
Closed

Move fastify to devDependency in lodestar-api #4159

dapplion opened this issue Jun 14, 2022 · 1 comment · Fixed by #4161
Assignees
@dadepo
Labels
scope-ux Issues for CLI UX or general consumer UX.

Comments

@dapplion
Copy link
Contributor

Describe the bug

lodestar-api defines client and server in the same package. That's very convenient for DX, but users should NOT have to install a server side REST framework to use a client.

Architect the types and exports in a way that's not necessary to have fastify as a direct dependency of lodestar-api

lodestar/packages/api/package.json

Line 71 in 04155c6

"fastify": "3.15.1",

@dapplion dapplion added the scope-ux Issues for CLI UX or general consumer UX. label Jun 14, 2022
@dapplion
Copy link
Contributor Author

Oh it was introduced in this mega commit and wasn't picked up by reviews

dfd4cdc#diff-069a572372e4f2574eb68db90e3d6ff4d0766296abec7b3c7b0f45b098d38fcaR72

@dadepo dadepo mentioned this issue Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dadepo dadepo

Labels
scope-ux Issues for CLI UX or general consumer UX.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have fastify back as dev dependency in lodestar-api ChainSafe/lodestar
2 participants
@dadepo @dapplion