Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make network classes startable once #4501

Closed
dapplion opened this issue Sep 1, 2022 · 0 comments · Fixed by #5588
Closed

Make network classes startable once #4501

dapplion opened this issue Sep 1, 2022 · 0 comments · Fixed by #5588
Labels
prio-low This is nice to have. scope-none Issues that do not fit within any of the other defined scopes.

Comments

@dapplion
Copy link
Contributor

dapplion commented Sep 1, 2022

Network classes can be started and stopped. This pattern is "forced" on us because of libp2p, but we don't needed.

This forces Lodestar to mantain multiple AbortControllers, since you need a new one for each start. However if we change the flow to only be startable once a single AbortController can be passed as constructor parameter, and throw on start if it's already aborted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-low This is nice to have. scope-none Issues that do not fit within any of the other defined scopes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: drop start stop pattern from Network where possible ChainSafe/lodestar
1 participant
@dapplion