-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix yarn check-readme #6300
Labels
meta-bug
Issues that identify a bug and require a fix.
scope-testing
Issues for adding test coverage, fixing existing tests or testing strategies.
Comments
nflaig
added
scope-testing
Issues for adding test coverage, fixing existing tests or testing strategies.
meta-bug
Issues that identify a bug and require a fix.
labels
Jan 15, 2024
@nflaig yes just a plain copy |
Some findings:
|
Nice catch!!! Your thoroughness is commendable @jeluard!!! It looks like we can pass a “—project” to the |
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
meta-bug
Issues that identify a bug and require a fix.
scope-testing
Issues for adding test coverage, fixing existing tests or testing strategies.
We actually do
lodestar/.github/workflows/test.yml
Lines 144 to 145 in 88744d8
But it doesn't seem to care at all
@jeluard how did you verify and determine the changes to make it compile, just copy pasted it into a .ts file?
Originally posted by @nflaig in #6297 (comment)
The text was updated successfully, but these errors were encountered: