Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big state hashTreeRoot() time in lodestar #6598

Open
twoeths opened this issue Mar 26, 2024 · 0 comments · May be fixed by #6939
Open

Big state hashTreeRoot() time in lodestar #6598

twoeths opened this issue Mar 26, 2024 · 0 comments · May be fixed by #6939
Labels
meta-feature-request Issues to track feature requests.

Comments

@twoeths
Copy link
Contributor

twoeths commented Mar 26, 2024

Problem description

state hashTreeRoot() takes up to 1s - 1.5s frequently, need to find a way to improve it

Screenshot 2024-03-26 at 15 11 25

this is likely to happen after processing an epoch, in rare case it could be up to 1.8s on holesky #6194

Solution description

Reduce it as much as possible

  • Improve our hash function either by SIMD here or (most likely) hashtree work by @wemeetagain
  • Find a way to consume it in persistent-merkle-tree

Additional context

No response
@twoeths twoeths added the meta-feature-request Issues to track feature requests. label Mar 26, 2024
@twoeths twoeths mentioned this issue Mar 26, 2024
Merged
@twoeths twoeths changed the title Big state hashTreeRoot() in lodestar Big state hashTreeRoot() time in lodestar Mar 27, 2024
@twoeths twoeths mentioned this issue Jul 1, 2024
Merged
@twoeths twoeths linked a pull request Jul 9, 2024 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-feature-request Issues to track feature requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: consume new ssz batch hash branch ChainSafe/lodestar
1 participant
@twoeths