Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ssz response to getLightClientUpdatesByRange #6841

Closed
nflaig opened this issue Jun 3, 2024 · 0 comments · Fixed by #7119
Closed

Add support for ssz response to getLightClientUpdatesByRange #6841

nflaig opened this issue Jun 3, 2024 · 0 comments · Fixed by #7119
Labels
scope-light-clients All issues regarding light client development.

Comments

@nflaig
Copy link
Member

nflaig commented Jun 3, 2024

As per spec this route needs to support ssz responses but the implementation deviates quite a lot from other routes. See implementation notes for details.

There has been previous work on this in #4641 and we might be able to reuse some code from there.

Can additional test our implementation against https://eth-light.xyz/, and other light client routes as well. Might need to set Access-Control-Expose-Headers: Eth-Consensus-Version to make it work with the browser.

@nflaig nflaig added the scope-light-clients All issues regarding light client development. label Jun 3, 2024
@nflaig nflaig changed the title Add support for ssz repsonse to getLightClientUpdatesByRange Add support for ssz response to getLightClientUpdatesByRange Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-light-clients All issues regarding light client development.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant