Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper user-agent in validator client http requests #6959

Closed
nflaig opened this issue Jul 15, 2024 · 2 comments · Fixed by #7106
Closed

Set proper user-agent in validator client http requests #6959

nflaig opened this issue Jul 15, 2024 · 2 comments · Fixed by #7106

Comments

@nflaig
Copy link
Member

nflaig commented Jul 15, 2024 •
edited
Loading

This is not that important but we could consider setting proper user-agent header as this might help debug issues (or adding workarounds).

Right now, we just set (fetch default)

User-Agent: node

We already set the Lodestar version in http requests to builder
@nflaig nflaig mentioned this issue Sep 24, 2024
Merged
@KaloyanTanev
Copy link

Thanks for that one, it was really helpful for running distributed validators.

@nflaig
Copy link
Member Author

nflaig commented Dec 5, 2024

Thanks for that one, it was really helpful for running distributed validators.

I wasn't sure if anyone even cares about the user-agent header but that's great to hear, thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: set proper user-agent in validator client http requests ChainSafe/lodestar
2 participants
@KaloyanTanev @nflaig