-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement HashComputationLevel using LinkedList #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
this is where it optimizes memory? |
g11tech
reviewed
Jul 24, 2024
wemeetagain
reviewed
Aug 2, 2024
wemeetagain
approved these changes
Aug 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
HashComputationGroup
andHashComputationLevel
to be able to reuse at the consumer side where it makes sense (for example: processBlocks, compute root for BeaconState.balances)Description
HashComputation
type and its utils to a separate classHashComputationLevel
to be a linked-list like to save memory allocation:hashtree
: allocatedestNodes
variable once, set it as defaultsubtreeFillToContents
+setNodesAtDepth
: destructure params in order not to allocate temporary objects at the consumer sidetest result was persisted here
part of #378
cc @wemeetagain @g11tech