Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download / Upload toasts notifications overlap each other #1465

Closed
asnaith opened this issue Aug 20, 2021 · 2 comments · Fixed by #1495
Closed

Download / Upload toasts notifications overlap each other #1465

asnaith opened this issue Aug 20, 2021 · 2 comments · Fixed by #1495
Assignees
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files

Comments

@asnaith
Copy link
Member

asnaith commented Aug 20, 2021

Description
Upload / Download toast modal dialogs overlap and do not stack on top of each other

Steps to Reproduce

  1. Login to Files
  2. Start the download for a file (choose a large sixe file so the toast is present for long enough)
  3. As one file is downloading start uploading a large file

Observed behavior
The toasts are displayed in the same area so one overlaps the other when both actions are being performed at the same time

Expected behavior
The toasts should stack so that both are readable to the user

Video

Untitled.mov

Desktop:

  • OS: macOS
  • Browser: Chrome
  • Version : 92.0.4515.107
@asnaith asnaith added Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files labels Aug 20, 2021
@tanmoyAtb tanmoyAtb self-assigned this Aug 24, 2021
@FSM1
Copy link
Contributor

FSM1 commented Aug 25, 2021

We should make sure that all toasts originate in the bottom right, Use a common ToastsContext.tsx to render all types of toasts - Confirmation, Progress, Error, etc.

Investigate if there are any suitable libraries we can use, that can handle all the required functionality.

Must be able to add test-id

@FSM1
Copy link
Contributor

FSM1 commented Aug 25, 2021

Hey team! Please add your planning poker estimate with ZenHub @RyRy79261 @Tbaut @tanmoyAtb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants