Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies whilst trying to add multiple files to modal #1506

Closed
asnaith opened this issue Sep 8, 2021 · 1 comment · Fixed by #1538
Closed

Inconsistencies whilst trying to add multiple files to modal #1506

asnaith opened this issue Sep 8, 2021 · 1 comment · Fixed by #1538
Assignees
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files

Comments

@asnaith
Copy link
Member

asnaith commented Sep 8, 2021

Description
There's an inconsistent behaviour whilst trying to add additional files for upload via this modal:

Screen Shot 2021-09-08 at 1 21 05 PM

Steps to Reproduce

  1. Login to files
  2. Click the upload button and choose a file
  3. Click the "Add more files" button and attempt to add an additional file to the modal

Observed behavior

  • On chrome: After the selection of the first file, each attempt to add more requires the user to select a file twice.

  • On safari: After the selection of the first file it's not possible to add any more to the modal.

Expected behavior
The user should be able to attach additional files as necessary without having to make 2 attempts.

Videos

Chrome behaviour (observe that it requires the additional file to be selected twice as the file picker is shown again after the selection):

Adding.Multiple.Files.Chome.mov

Safari behaviour (observe it is not possible to add more than one file to the modal):

Adding.multiple.files.Safari.mov

Desktop:

  • OS: macOS
  • Browser: Chrome / Safari
  • Version : 93.0.4577.63 / 14.1.2 (16611.3.10.1.6)

Notes

  • Works as expected if adding multiple files at once (ctrl + click selection)
  • Works as expected for drag and drop
  • Works as expected in firefox
@asnaith asnaith added Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files labels Sep 8, 2021
@Tbaut
Copy link
Collaborator

Tbaut commented Sep 9, 2021

Thanks, I can reproduce on Brave, not on FF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants