Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't spam the api on user lookup - debounce calls #1551

Closed
Tbaut opened this issue Sep 21, 2021 · 0 comments · Fixed by #1553
Closed

Don't spam the api on user lookup - debounce calls #1551

Tbaut opened this issue Sep 21, 2021 · 0 comments · Fixed by #1553
Assignees
@Tbaut
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files

Comments

@Tbaut
Copy link
Collaborator

Tbaut commented Sep 21, 2021

When we lookup users right now for the sharing modal, we're spamming the api and fire a request for every single character types. This is leading to the calls ultimately failing and the UI to hang.

We should make sure this is debounced.
@Tbaut Tbaut added Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files labels Sep 21, 2021
@Tbaut Tbaut self-assigned this Sep 21, 2021
@Tbaut Tbaut mentioned this issue Sep 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tbaut Tbaut

Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Product: Files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix user lookup spamming the api, and throwing ChainSafe/ui-monorepo
1 participant
@Tbaut