Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals cut off at the top (mobile) #1664

Closed
serenaho opened this issue Oct 27, 2021 · 2 comments · Fixed by #1715
Closed

Modals cut off at the top (mobile) #1664

serenaho opened this issue Oct 27, 2021 · 2 comments · Fixed by #1715
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Priority: P2 Medium Added to issues relating to a medium severity bugs.

Comments

@serenaho
Copy link
Collaborator

serenaho commented Oct 27, 2021

Modal #1: When opening the Info menu item in mobile landscape orientation, the modal is cut off at the top of the screen with no option to scroll up to see the whole thing.

The swipe-up gesture moves the background content instead (see gap above Close button).

https://images.zenhubusercontent.com/285884697/39c73530-bf2e-4701-9f8d-cbf6f6beea3d/info_modal_cut_off.mp4

Modal #2: Same issue but with the Share menu item.

Screenshot_20211027-105626.png

@Tbaut
Copy link
Collaborator

Tbaut commented Nov 2, 2021

I believe this is a general absolute positioning problem for all the modals.

@FSM1 FSM1 added Planning: Needs estimation Priority: P2 Medium Added to issues relating to a medium severity bugs. Issue: Bug 🐛 Added to issues relating to a critical severity bugs. and removed Planning: Needs estimation labels Nov 3, 2021
@FSM1
Copy link
Contributor

FSM1 commented Nov 3, 2021

Could be quite a significant change to enable this. Investigate whether the changes required to make this happen would be very significant, and if so, whether it makes sense to hold on with this until we settle down on the component library select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Priority: P2 Medium Added to issues relating to a medium severity bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants