Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bin Still Clickable After Closing (Mobile) #1683

Closed
serenaho opened this issue Oct 29, 2021 · 7 comments · Fixed by #1730
Closed

Bin Still Clickable After Closing (Mobile) #1683

serenaho opened this issue Oct 29, 2021 · 7 comments · Fixed by #1730
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs.

Comments

@serenaho
Copy link

The Bin menu item from left navigation remains active on screen (even though it is invisible) when navigating to different screens.

https://images.zenhubusercontent.com/285884697/c4894974-9868-45b9-8f40-46bdb27017cf/faulty_nav___portrait__mobile_.mp4

@Tbaut Tbaut added the Issue: Bug 🐛 Added to issues relating to a critical severity bugs. label Nov 1, 2021
@Tbaut
Copy link
Collaborator

Tbaut commented Nov 1, 2021

@serenaho did you test this on a real device?
I tried both with Firefox emulation and with Firefox on android (real device) and couldn't reproduce. Is that on safari with iphone? Can you reproduce with safari on desktop as well?

@serenaho
Copy link
Author

serenaho commented Nov 1, 2021

@Tbaut I discovered it while on google chrome with my google pixel 3 phone!

@serenaho
Copy link
Author

serenaho commented Nov 1, 2021

I just did it again on desktop using google chrome and macbook:

Faulty.Nav.-.Portrait.Desktop.mov

@Tbaut
Copy link
Collaborator

Tbaut commented Nov 2, 2021

Ok I can reproduce on Brave. The menu is hidden (so anything in the menu, the Bin/Home/Shared, the settings etc.,), but can still be clicked for a second. Waiting a sec and the problem doesn't appear any more (the section becomes inactive). This looks like it's a transition issue.

@RyRy79261
Copy link
Contributor

Tried on my mozilla, only when I manually set transitions to 0.25 speed could I grab it

In theory the window is 400ms for someone to do this

@FSM1
Copy link
Contributor

FSM1 commented Nov 9, 2021

What if we just render null if the drawer is closed?

@RyRy79261
Copy link
Contributor

@FSM1 so the issue would be a bit of graphics popping, in theory, a pseudo-element as a click block could suffice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants