Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share Explainer Modal - Close button position #1734

Closed
FSM1 opened this issue Nov 11, 2021 · 1 comment · Fixed by #1735
Closed

Share Explainer Modal - Close button position #1734

FSM1 opened this issue Nov 11, 2021 · 1 comment · Fixed by #1735
Assignees
@Tbaut
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Priority: P1 High Added to issues relating to a high severity bugs.

Comments

@FSM1
Copy link
Contributor

FSM1 commented Nov 11, 2021 •
edited
Loading

Describe the bug
Close button on modal is positioned outside of the modal

To Reproduce
Steps to reproduce the behavior:

  1. Log in to the system with a new account/or force the explainer modal to show by fiddling with state
  2. Navigate to Shared Overview

Expected behavior
Modal close button should be inside the modal

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Firefox
  • Version: 94

Additional context
Add any other context about the problem here.
@FSM1 FSM1 added Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Priority: P1 High Added to issues relating to a high severity bugs. labels Nov 11, 2021
@Tbaut
Copy link
Collaborator

Tbaut commented Nov 11, 2021

Damn, I swear i checked it out (this one and the team fake door). Will take a look

@Tbaut Tbaut self-assigned this Nov 11, 2021
@Tbaut Tbaut mentioned this issue Nov 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tbaut Tbaut

Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Priority: P1 High Added to issues relating to a high severity bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix close button at the wrong place ChainSafe/ui-monorepo
2 participants
@FSM1 @Tbaut