Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS video controls displayed upon preview modal closure (iOS only) #1970

Closed
asnaith opened this issue Feb 23, 2022 · 5 comments
Closed

OS video controls displayed upon preview modal closure (iOS only) #1970

asnaith opened this issue Feb 23, 2022 · 5 comments
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs.

Comments

@asnaith
Copy link
Contributor

asnaith commented Feb 23, 2022

Description
When you preview a video file on iOS within safari, if you close the preview modal without playing the video then the OS video control interface is left behind and also have to be closed before you can return to the main drive page.

Steps to Reproduce

  1. Log in to Files on Safari within iOS
  2. Upload a movie
  3. Preview movie
  4. Close preview modal without playing the video

Observed behavior
After closing the video the OS video controls are left behind and have to be closed before you can return to the drive page.

Expected behavior
Closing the modal should take the user back to the main drive page

Video

video-preview-issue-ios.mov

Notes

  • This is specific to Safari on iOS. It doesn't happen on Firefox on iOS or on MacOS version of Safari, Android etc.

  • iOS is the only platform that doesn't auto-play the videos when they are previewed. If you play the video and then close the preview modal everything works so perhaps the fix for this is to ensure videos auto-play like they do on every other platform?

@asnaith asnaith added the Issue: Bug 🐛 Added to issues relating to a critical severity bugs. label Feb 23, 2022
@asnaith asnaith changed the title OS video controls displayed upon modal closure (iOS only) OS video controls displayed upon preview modal closure (iOS only) Feb 23, 2022
@tanmoyAtb tanmoyAtb self-assigned this Feb 27, 2022
@tanmoyAtb
Copy link
Contributor

tanmoyAtb commented Mar 1, 2022

Hey @asnaith , I could not really replicate the issue on my side.
I'm using safari on an iPhone. I tried closing the preview before starting play on a video, and during playing.

156218314-ae334dd0-7ec5-4dc0-bf89-b4eaaad9e19f.mov

@asnaith
Copy link
Contributor Author

asnaith commented Mar 1, 2022

@tanmoyAtb oh strange! I can still reproduce it, could you try with the same file I am using? ChainSafe Files link

Also, I'm on iOS 15.3.1 - I know Safari had a lot of new changes in iOS 15 so perhaps it's version-specific too.

I have reproduced it on another iPhone, a different model to my personal device but it was still on iOS 15.3.1

@tanmoyAtb
Copy link
Contributor

@tanmoyAtb oh strange! I can still reproduce it, could you try with the same file I am using? ChainSafe Files link

Also, I'm on iOS 15.3.1 - I know Safari had a lot of new changes in iOS 15 so perhaps it's version-specific too.

I have reproduced it on another iPhone, a different model to my personal device but it was still on iOS 15.3.1

Looks like I had an older version, and it was working there. I'm upgrading to 15.3.1 now, will check it out.

@tanmoyAtb
Copy link
Contributor

Hey @asnaith I tried to replicate this again, it still seems to be working with 15.3.1 on my device.

@asnaith
Copy link
Contributor Author

asnaith commented Mar 10, 2022

Hey @asnaith I tried to replicate this again, it still seems to be working with 15.3.1 on my device.

Yeah this bug is strange. I just checked again on 2 different iPhones, both on 15.3.1 and it's still happening on those for me 🤦‍♂️.

Due to the fact it only happens if you don't play the video before closing (and that most users will want to play when they go to the preview) and it's not affecting all iPhones / iOS versions then maybe we need to keep this in backlog until we have better reproduction steps?

It's feeling like more of a quirk with the way Safari and its video controls are handling the video but it's strange that it's not happening 100%. Not sure if it's related to auto-play.

@tanmoyAtb tanmoyAtb removed their assignment Mar 15, 2022
@FSM1 FSM1 closed this as completed Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs.
Projects
None yet
Development

No branches or pull requests

3 participants