Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC1155 support for SygmaClient #889

Closed
kalambet opened this issue Mar 4, 2024 · 0 comments · Fixed by #896
Closed

Add ERC1155 support for SygmaClient #889

kalambet opened this issue Mar 4, 2024 · 0 comments · Fixed by #896
Labels
Priority: P1 Added to issues and PRs relating to a high severity bugs. sygma Type: Enhancement Added to issues and PRs when a change includes improvements or optimizations.

Comments

@kalambet
Copy link
Member

kalambet commented Mar 4, 2024

Summary
Add ERC1155 support to the SygmaClient.

Suggested features or ways to address the summary
CreateFungibleTransfer methods need to be added to the SygmaClient but ERC1155 specifics also need to be taken into account. It is not only the token ID but also the amount that needs to be passed.

Support for ERC1155Handler and ERC1155Safe also should be implemented.
The fee handler should remain Basic.

Motivation
All the contracts that got deployed are not ERC721 but ERC1155 so the SygmaClient functionality should be accommodated.

Acceptance Criteria
All the basic logic for the 1155 support needs to be added. So far no testing is needed. There will be a separate issue for that.
@kalambet kalambet mentioned this issue Mar 4, 2024
Open
@kalambet kalambet added Priority: P1 Added to issues and PRs relating to a high severity bugs. Type: Enhancement Added to issues and PRs when a change includes improvements or optimizations. labels Mar 4, 2024
@kalambet kalambet mentioned this issue Mar 4, 2024
Open
@kalambet kalambet mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: P1 Added to issues and PRs relating to a high severity bugs. sygma Type: Enhancement Added to issues and PRs when a change includes improvements or optimizations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ERC1155 Support ChainSafe/web3.unity
2 participants
@kalambet @kantagara