Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java 9, 10, and 11 #31

Closed
rjdavis3 opened this issue Feb 4, 2020 · 3 comments
Closed

Support Java 9, 10, and 11 #31

rjdavis3 opened this issue Feb 4, 2020 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@rjdavis3
Copy link
Member

rjdavis3 commented Feb 4, 2020

shopify-sdk relies on JAXB APIs that were part of the JDK in Java 8 but lost support in later versions. We should ensure that the shopify-sdk works with Java 8, 9, 10, and 11

Hopefully we can accomplish this by just including the Maven Dependencies for JAXB that are now excluded.

We should start running CI builds with different JDK versions to ensure we maintain support.

https://stackoverflow.com/questions/43574426/how-to-resolve-java-lang-noclassdeffounderror-javax-xml-bind-jaxbexception-in-j

@rjdavis3 rjdavis3 added bug Something isn't working help wanted Extra attention is needed labels Feb 4, 2020
@rjdavis3 rjdavis3 self-assigned this Feb 4, 2020
@ryankazokas
Copy link
Member

@rjdavis3 Yeah i think we can do this.
We'll have to push to maven with our minimal supported version or it won't work with older projects.
Compiled with java 11 and pushing to maven will start giving errors on projects that are using earlier versions:

com/shopify/ShopifySdk has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

Travis actually supports testing multiple JDK's:
https://blog.travis-ci.com/support_for_multiple_jdks/

However we may have to address #13 if we are going to be running the tests against multiple sdks

@rjdavis3
Copy link
Member Author

@ryankazokas I would like to run this against multiple JDKs if possible. This way we can ensure we maintain support.

@rjdavis3
Copy link
Member Author

rjdavis3 commented Apr 6, 2020

Implemented by 2.0.0 release.

@rjdavis3 rjdavis3 closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants