Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical Issues in underlying libraries #16

Open
bhatt-deep opened this issue May 30, 2024 · 0 comments
Open

Critical Issues in underlying libraries #16

bhatt-deep opened this issue May 30, 2024 · 0 comments

Comments

@bhatt-deep
Copy link
Collaborator

bhatt-deep commented May 30, 2024

Issue: Long term impact -- increasingly difficult to maintain fork. This ticket is to future proof the current code to allow for future updates.

Coding and decoding of CBOR is inconsistent. Elder has provided a fix (below) which is a change in the CBOR library. It is a bigger and more pervasive problem. This needs to get resolved.

AC:
tbd

CONTEXT:
There are also some structural things that need work. The only reason why this library works is because I have fixed a couple of critical issues in the underlying libraries.

You can see the discussion in the following Github issues/PRs
Python-Cardano/pycardano#331
agronholm/cbor2#225

The current library works by pulling in my private fixes for these issues:
https://github.com/theeldermillenial/pycardano/tree/bugfix/datum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant