Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter is not being reset on localTick() #1

Open
littleant opened this issue Oct 10, 2024 · 0 comments
Open

Counter is not being reset on localTick() #1

littleant opened this issue Oct 10, 2024 · 0 comments

Comments

@littleant
Copy link

Hi,

I was wondering, if there is a reason why the counter is never reset to 0, when localTick() is being called.
In the referenced paper the counter is always set to 0, when the value for the wall clock is being updated.

See page 5, figure 5 in the paper: The else-branch sets the counter c of node j to 0. The else-branch is being reached if the physical time l has increased.

By not resetting the counter value, we increase the risk of overflowing it. Only receiving an event will reset the counter, I believe.

I think adding counter = 0 in the copy()-call below should fix it:

Ok(local.copy(timestamp = wallClockTime))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant