Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is possible to have two commands named the same #2497

Closed
Mm2PL opened this issue Mar 5, 2021 · 1 comment · Fixed by #4322
Closed

It is possible to have two commands named the same #2497

Mm2PL opened this issue Mar 5, 2021 · 1 comment · Fixed by #4322
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user

Comments

@Mm2PL
Copy link
Collaborator

Mm2PL commented Mar 5, 2021

Describe the bug

You can have two commands named the same string of characters, which is confusing.

To reproduce

  1. Add a command (/test123)
  2. Add another one with the same name but different output
  3. Observe that the first command in the list will get executed and the second one won't.

Screenshots

2021-03-05_14-31
2021-03-05_14-31_1

Chatterino version

Chatterino Nightly + Dankerino patches 2.2.3-beta2 (commit 3a58958) based on upstream b2aa370

Operating system

Ubuntu 20.04.01
@Mm2PL Mm2PL added the bug Something isn't working as intended, or works in a confusing/unintuitive way for the user label Mar 5, 2021
@jupjohn
Copy link
Contributor

jupjohn commented Mar 22, 2022

Can reproduce, Chatterino 2.3.4 (commit baeec59a). Will look into adding validation before a command is saved/cell is unfocused

@askepticaldreamer askepticaldreamer mentioned this issue Jan 21, 2023
Merged
1 task
@PsycloneTM PsycloneTM mentioned this issue Feb 20, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Warn for commands with duplicate triggers askepticaldreamer/chatterino2
2 participants
@jupjohn @Mm2PL