Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/setgame matching "too loose" #2636

Closed
ALazyMeme opened this issue Apr 17, 2021 · 1 comment · Fixed by #2825
Closed

/setgame matching "too loose" #2636

ALazyMeme opened this issue Apr 17, 2021 · 1 comment · Fixed by #2825
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user

Comments

@ALazyMeme
Copy link
Collaborator

ALazyMeme commented Apr 17, 2021

Describe the bug
Helix is sometimes horribly incorrect for game titles. This can potentially result in something like /setgame terraria actually setting the game to Sub Terrania or Terraria 2.

Potential Solution
Converting game titles from the previous search to lowercase, then best matching according to that. For example...

Below is the response from helix for searching for the game. If we were to convert the game titles to lowercase and compare the user's input to the game titles, we'd find that it best matches to id 31376 as opposed to just matching to the first entry.
image

EDIT: This issue is actually in reference to the already added /setgame feature. Currently it doesn't match some games exactly. The fix to this would be to convert the query to lowercase, search for the game, see which game best matches and use the id to set the game.

@ALazyMeme ALazyMeme added the bug Something isn't working as intended, or works in a confusing/unintuitive way for the user label Apr 17, 2021
@jupjohn
Copy link
Contributor

jupjohn commented May 26, 2021

Picking this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants