Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak due to loading recent messages on reconnects. #4497

Closed
4 tasks done
somso2e opened this issue Apr 1, 2023 · 1 comment · Fixed by #4499
Closed
4 tasks done

Memory leak due to loading recent messages on reconnects. #4497

somso2e opened this issue Apr 1, 2023 · 1 comment · Fixed by #4499
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user

Comments

@somso2e
Copy link

somso2e commented Apr 1, 2023

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

There is about 100MB -150MB of memory leak after each reconnect and loading recent messages.

How to reproduce:

  • Turn on load history messages and just spam ctrl+f5 to reconnect a bunch of times then disable it and do the same thing. Now compare memory usage.

Screenshots

Here it is after 15-16 reconnects:
image
And here its before any reconnects:
imimage age

OS and Chatterino Version

Chatterino Nightly 2.4.2 (commit 7a081fd) built on 2023-03-30 with Qt 5.15.2, Windows SDK, MSVC 193431943, Crashpad, Running Windows 11 Pro Version 22H2
@somso2e somso2e added the issue-report An issue reported by a user. label Apr 1, 2023
@leon-richardt
Copy link
Collaborator

Can reproduce this on Arch, commit b9e87dcd2

@pajlada pajlada added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user and removed issue-report An issue reported by a user. labels Apr 1, 2023
@pajlada pajlada mentioned this issue Apr 1, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix memory leak when using the Recent Messages API Chatterino/chatterino2
3 participants
@pajlada @leon-richardt @somso2e