Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QObjectRef in favor of QPointer #4632

Closed
4 tasks done
fourtf opened this issue May 14, 2023 · 0 comments · Fixed by #4666
Closed
4 tasks done

Remove QObjectRef in favor of QPointer #4632

fourtf opened this issue May 14, 2023 · 0 comments · Fixed by #4666

Comments

@fourtf
Copy link
Member

fourtf commented May 14, 2023

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

We have a class called QObjectRef which is a pointer to a QObject which is reset when the referenced object is destroyed. It looks, however, like Qt itself has an equivalent class called QPointer. https://doc.qt.io/qt-6/qpointer.html

We can replace the QObjectRef usages and remove the class.

Screenshots

No response

OS and Chatterino Version

Chatterino 2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant