Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ing tab autocomplete to streamer username #5190

Closed
4 tasks done
bmundt opened this issue Feb 21, 2024 · 7 comments · Fixed by #5193
Closed
4 tasks done

@ing tab autocomplete to streamer username #5190

bmundt opened this issue Feb 21, 2024 · 7 comments · Fixed by #5193

Comments

@bmundt
Copy link

bmundt commented Feb 21, 2024

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

I cannot @ tab autocomplete the streamer. I see from other issues that the @ autocomplete has issues pulling from the whole chat and only pulls recent chatters. But, I feel like there should be an exception to this for the streamer, so you can @ them easily. Maybe even a shortcut to go to the streamer, since often people like to mimic the name of the streamer.

Screenshots

image

image

OS and Chatterino Version

Chatterino 2.4.6 (commit eb8c7f2) built with Qt 6.5.0, MSVC 193532217 Running on Windows 10 Version 22H2, kernel: 10.0.19045

@bmundt bmundt added the issue-report An issue reported by a user. label Feb 21, 2024
@Felanbird
Copy link
Collaborator

Non-mods can't access the viewerlist anymore so we cannot confirm the streamer has the chat open, Hasan may be an exception to this logic due to the fact that he often has Chatterino on screen, but we can't magically use that information for every channel.

I'm not sure if I like the idea of faking a broadcaster into the @mention list

@bmundt
Copy link
Author

bmundt commented Feb 21, 2024

Or perhaps just having it at the top of the mention list like in the normal twitch website.

image

@Felanbird
Copy link
Collaborator

Felanbird commented Feb 21, 2024

He's at the top of the mention list because you are still allowed to view the viewerlist in browser chat, that suggestion doesn't change my previous answer

Actually I partially misunderstood what you meant, that suggestion would probably require some refactoring since the user at the top is the most-recent, but would not resolve your original issue.

@KleberPF
Copy link
Contributor

On the browser chat, even when the streamer is offline, they are the first option when typing @. I agree that it would be nice to also do this on Chatterino.

@pajlada
Copy link
Member

pajlada commented Feb 21, 2024

I am fine with adding the streamer to the user autocomplete list, even if they're not in the chatters list or among the recent chatters.
When added/fixed, I am fine with there be a setting that can disable this behaviour.

If my memory isn't failing me, I believe we did this before - prior to the chatter list changes

@pajlada pajlada added enhancement and removed issue-report An issue reported by a user. labels Feb 21, 2024
@Felanbird
Copy link
Collaborator

If my memory isn't failing me, I believe we did this before - prior to the chatter list changes

I think we do have that feature still but Hasan has too many active chatters that he's eventually kicked out of the list

@bmundt
Copy link
Author

bmundt commented Feb 22, 2024

Yeah you're right he is getting kicked out. I went to a smaller streamer, and can see their name right away when I hit @. Although, after sitting in that chat for a minute and having about 15 messages come through, their name is no longer at the top, but at the bottom, it is still there at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants