Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging tab across lines may cause empty space between tabs #5450

Closed
4 tasks done
jupjohn opened this issue Jun 11, 2024 · 2 comments · Fixed by #5612
Closed
4 tasks done

Dragging tab across lines may cause empty space between tabs #5450

jupjohn opened this issue Jun 11, 2024 · 2 comments · Fixed by #5612
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user no-reproduction-steps A bug or crash that doesn't have any known steps to reproduce

Comments

@jupjohn
Copy link
Contributor

jupjohn commented Jun 11, 2024

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

While I haven't found a way to replicate this issue, here's my rough memory of how I caused it:

  1. Have multiple lines of tabs
  2. Drag the first tab on the second row up into the first row (unsure if it was left or right of the first row's first tab)
  3. Maybe drag the tab back down to the second row in the same movement
  4. First row's first tab is now pushed out by a tab width???

Screenshots

God I wish I had the sense to screenshot instead of try to reproduce straight away, but I did not... so here's an artistic rendition of the before & after:

Before:
image

After:
image

OS and Chatterino Version

Chatterino 2.5.1 (commit d2316af) built with Qt 6.7.1 Running on Arch Linux, kernel: 6.9.3-zen1-1-zen

@jupjohn jupjohn added the issue-report An issue reported by a user. label Jun 11, 2024
@pajlada pajlada added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user no-reproduction-steps A bug or crash that doesn't have any known steps to reproduce and removed issue-report An issue reported by a user. labels Jun 11, 2024
@8thony
Copy link
Contributor

8thony commented Jun 11, 2024

Can reproduce
chatterino
Chatterino Nightly 2.5.1 (commit 25284fc) Qt 6.7.1 Running on Windows 10

@kornes
Copy link
Contributor

kornes commented Jun 11, 2024

if (this->pos() == targetPos)
{
return;
}

early return i added recently seems to be a reason, removing it masks the issue and it works as before.
Notebook layouting needs some love and refactoring which i dont have time to commit to, so for now suggest to just remove above change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user no-reproduction-steps A bug or crash that doesn't have any known steps to reproduce
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants